WIP: Support table logging for mlflow, too #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a `LogPredictionCallback` for both "wandb" and "mlflow" if specified. In `log_prediction_callback_factory`, create a generic table and make it specific only if the newly added `logger` argument is set to "wandb" resp. "mlflow". See axolotl-ai-cloud#1505
winglian
approved these changes
Apr 9, 2024
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* WIP: Support table logging for mlflow, too Create a `LogPredictionCallback` for both "wandb" and "mlflow" if specified. In `log_prediction_callback_factory`, create a generic table and make it specific only if the newly added `logger` argument is set to "wandb" resp. "mlflow". See #1505 * chore: lint * add additional clause for mlflow as it's optional * Fix circular imports --------- Co-authored-by: Dave Farago <[email protected]> Co-authored-by: Wing Lian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a
LogPredictionCallbackfor both "wandb" and "mlflow" if specified.In
log_prediction_callback_factory, create a generic table and make it specific only if the newly addedloggerargument is set to "wandb" resp. "mlflow".See #1505
Motivation and Context
We are using MLFlow, not Weights & Biases, and would like to use the feature #490 for MLFlow.
How has this been tested?
I am happy to add some test case if necessary, but I would need help pointing me to the right pytest file to add a test case that does specify "mlflow".
Types of changes
Social Handles (Optional)
dball9 on discord